Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hls Decreasing the number will make download slower but stable. #1160

Merged
merged 2 commits into from
Jun 27, 2023
Merged

refactor: hls Decreasing the number will make download slower but stable. #1160

merged 2 commits into from
Jun 27, 2023

Conversation

candrapersada
Copy link
Contributor

@candrapersada candrapersada commented Jun 25, 2023

NOTE :- Increasing the number will make the download faster but less stable and Decreasing the number will make download slower but stable.
and how auto clean ${HOME}/.cache/hls-temp after the download is complete

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

NOTE :- Increasing the number will make the download faster but less stable and Decreasing the number will make download slower but stable.. Decrease the number if the script is hanging out during download process.. - This applies if you use curl for downloading (I know you have reasons for not having aria2 installed), It doesn't affect in aria2 case and leaving it default will be recommended. :)
@candrapersada candrapersada requested a review from port19x as a code owner June 25, 2023 01:45
@candrapersada candrapersada changed the title Update ani-cli refactor: hls Decreasing the number will make download slower but stable. Jun 25, 2023
Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just go with the default number of connections (36)

ani-cli Outdated Show resolved Hide resolved
@CoolnsX
Copy link
Collaborator

CoolnsX commented Jun 25, 2023

No don't, if you have aria2c don't decrease download, as aria handles parallel download perfectly, but if you don't have aria then you can go with or with this formula <download_speed_in_MBps> * 3

@CoolnsX
Copy link
Collaborator

CoolnsX commented Jun 25, 2023

I think you didn't understand the concept of my script

Co-authored-by: port19 <port19@port19.xyz>
@candrapersada
Copy link
Contributor Author

but if use always many parallel download HLS video download will be broken.

@CoolnsX
Copy link
Collaborator

CoolnsX commented Jun 25, 2023

You don't have aria2c installed?? Or are u testing it on ISH?

@candrapersada
Copy link
Contributor Author

aria2c installed

@candrapersada
Copy link
Contributor Author

and why cleanup not working in ani-cli ${HOME}/.cache/hls-temp/file.ts after the download is complete to download the next episode?

@port19x port19x merged commit 967dcdd into pystardust:master Jun 27, 2023
@candrapersada candrapersada deleted the patch-3 branch June 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants