Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hex decryption #1171

Merged
merged 23 commits into from
Jul 9, 2023
Merged

fix: hex decryption #1171

merged 23 commits into from
Jul 9, 2023

Conversation

port19x
Copy link
Collaborator

@port19x port19x commented Jul 9, 2023 •
edited
Loading

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

CoolnsX and others added 23 commits June 30, 2023 22:22
@CoolnsX
fix : hex decryption
60830c4
@CoolnsX
choke: version bump
6a0c7ae
@CoolnsX
fix: using inbuilt for len checking
ce3e33e
@CoolnsX
feat: bypass debug in some function to avoid spamming
94b231c
@CoolnsX
choke: logic issue
116fe4f
@CoolnsX
choke on choke: debug output on non-debug command
bd7e2ad
@CoolnsX
choke on choke on choke: shfmt
d28bff7
@CoolnsX
feat: logic optimisation
1db9138
@CoolnsX
fix: just a minor, nothing to look at
277c68d
@CoolnsX
feat: cleanup
18fe758
@CoolnsX
fix: temp file cleanup and UI changes
3df08c3
@CoolnsX
choke: shfmt
4fb22c2
@CoolnsX
feat: replaced bypass_debug function with one-liners
7b5db79
@71zenith
feat: new provider (rab)
914d155 
fix: cleanup of fetching info
@71zenith
fix: remove unnecessary removal of lines
8186003
@71zenith
fix: only cleanup if no debug
e217b95
@71zenith
refactor: remove unnecessary if check
aa6ffb6
@71zenith
fix: redirect check output to /dev/null
5bfa852
@71zenith
refactor: replace hardcoded values with variables
054b1cd
@71zenith
feat: remove hls in favour of yt-dlp
d241aa7
@71zenith
docs: add yt-dlp as a dependency
fa3c462
@CoolnsX
feat: Title display
040bffc
@71zenith
docs: append instructions to steam deck copy paste script
13c6ce3
@port19x
Copy link
Collaborator Author

port19x commented Jul 9, 2023

Thoroughly tested ✅

@71zenith 71zenith self-requested a review July 9, 2023 12:23
@port19x port19x merged commit 353bf56 into master Jul 9, 2023
@port19x port19x deleted the hex_decryption branch July 9, 2023 12:56
@CoolnsX
Copy link
Collaborator

CoolnsX commented Jul 9, 2023

fuck, I had pointed some issues in previous PR, no wonder no of issues are still 8. closing them manually

This was referenced Jul 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@71zenith 71zenith 71zenith approved these changes

@justchokingaround justchokingaround Awaiting requested review from justchokingaround justchokingaround is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@port19x @CoolnsX @71zenith