Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rofi flag #1186

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: add rofi flag #1186

merged 2 commits into from
Aug 2, 2023

Conversation

masha-sh
Copy link
Contributor

@masha-sh masha-sh commented Aug 1, 2023

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@masha-sh
Copy link
Contributor Author

masha-sh commented Aug 1, 2023

i just think it's a bit hard for people to figure out the existence of such a feature in the script, since it isn't really mentionned anywhere. hopefully adding a flag for it will bring more attention to it

@port19x port19x merged commit 1eb18c9 into pystardust:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants