Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --skip-title <title> #1253

Merged
merged 8 commits into from
Jan 3, 2024
Merged

Conversation

LeFlorians
Copy link
Contributor

@LeFlorians LeFlorians commented Dec 25, 2023

Add --skip-title <title>

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

I added the --skip-title <title> cmdline argument.
I did this because it wouldn't skip One Piece intros with the default title of "1P".

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
    [x] Tested the above

ani-cli.1 Outdated Show resolved Hide resolved
Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what shfmt was complaining about

ani-cli Outdated Show resolved Hide resolved
Co-authored-by: port19 <port19@port19.xyz>
ani-cli Show resolved Hide resolved
Co-authored-by: port19 <port19@port19.xyz>
@port19x port19x merged commit be32fb7 into pystardust:master Jan 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants