feat: no-detach

[port19x]

Pull Request Template

Type of change

• Bug fix
• Feature
• Documentation update

Description

fixes #1261

Checklist

• any anime playing
• bumped version

---

• -h help info is up to date
• Readme is up to date
• Man page is up to date

[germaniuss]

Awesome you're actually doing this. Locally I also removed the >/dev/null 2>&1 & at the end since I believe we do not want to redirect the mpv output (nor open it in a background process). Though to be fair I am not knowledgeble enough about bash nor terminal emulators to actually know is that make a difference.

[port19x]

Can you test if it works like this as well?

[germaniuss]

Awesome you're actually doing this. Locally I also removed the >/dev/null 2>&1 & at the end since I believe we do not want to redirect the mpv output (nor open it in a background process). Though to be fair I am not knowledgeble enough about bash nor terminal emulators to actually know is that make a difference.

@port19x Sorry for getting back to you so late, had a pretty hectic week. Just tested it out, it does not seem to properly function without this (the anime is played in the background and I have to pkill mpv. I modified the sript to do $([ "no_detach" == 0 ] && echo ">/dev/null 2>&1 &") ;; at the end and it seems to work. Is there any technical reason not to do it?

[port19x]

Awesome you're actually doing this. Locally I also removed the >/dev/null 2>&1 & at the end since I believe we do not want to redirect the mpv output (nor open it in a background process). Though to be fair I am not knowledgeble enough about bash nor terminal emulators to actually know is that make a difference.

@port19x Sorry for getting back to you so late, had a pretty hectic week. Just tested it out, it does not seem to properly function without this (the anime is played in the background and I have to pkill mpv. I modified the sript to do $([ "no_detach" == 0 ] && echo ">/dev/null 2>&1 &") ;; at the end and it seems to work. Is there any technical reason not to do it?

Nah, I'll patch it