Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ani-skip not working in continue #1317

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

Woreec
Copy link
Contributor

@Woreec Woreec commented Apr 13, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Small fix for #1313, it didnt work correcly in continue mode.
I must have forgotten to test continue correcly after the last change in that PR, sorry about that.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@Woreec Woreec marked this pull request as ready for review April 13, 2024 20:47
@Woreec Woreec requested a review from Derisis13 as a code owner April 13, 2024 20:47
@port19x port19x merged commit a01249b into pystardust:master May 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants