Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Dead Wixmp Provider #1346

Merged
merged 2 commits into from
May 25, 2024
Merged

refactor: Remove Dead Wixmp Provider #1346

merged 2 commits into from
May 25, 2024

Conversation

CoolnsX
Copy link
Collaborator

@CoolnsX CoolnsX commented May 24, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@CoolnsX CoolnsX requested a review from Derisis13 as a code owner May 24, 2024 07:18
@CoolnsX CoolnsX changed the title Refactor: Remove Dead Wixmp Provider refactor: Remove Dead Wixmp Provider May 24, 2024
Copy link
Collaborator

@71zenith 71zenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@71zenith 71zenith merged commit bd642cc into master May 25, 2024
7 checks passed
@71zenith 71zenith deleted the dead_wix branch May 25, 2024 16:15
@skyler-0
Copy link
Contributor

skyler-0 commented Sep 3, 2024

the provider was not dead, also ani-cli now uses mp4 quality by default in 4.9 (atleast for me)
4.9 screenshot:
image
4.8 screenshot from my phone:
Screenshot_20240903-141457
Anime: Dress up darling
Episode 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants