Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update title in history file #1360

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: update title in history file #1360

merged 2 commits into from
Jun 10, 2024

Conversation

71zenith
Copy link
Collaborator

@71zenith 71zenith commented Jun 3, 2024

fix: update outdated titles in history selection

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

fix: update outdated titles in history selection
@71zenith 71zenith requested a review from Derisis13 as a code owner June 3, 2024 17:15
@71zenith
Copy link
Collaborator Author

71zenith commented Jun 3, 2024

I've done my preliminary testing however hist file can be widely different from user to user. I'll appreciate more testing

chore: version bump v4.8.8 -> v4.8.9
@port19x
Copy link
Collaborator

port19x commented Jun 6, 2024

Wow

Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just blocking this so I can test on friday / saturday

Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally forgot to test this.
But since it's a small change I'll just merge as is

@port19x port19x merged commit 9e8ea4a into master Jun 10, 2024
7 checks passed
@port19x port19x deleted the update_hist branch June 10, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct the number of available episodes of seasonal anime titles from history when watching it
3 participants