Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue where a non-working Alt link gets used when on iSH #1403

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

Lockl00p
Copy link
Contributor

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

How the hell did this happen?
I couldn’t test sync play as I don’t have an actual PC on me atm.
Quality doesn’t work on the current version so it won’t work here either. This isn’t to fix that problem.
I don’t have ani-skip so I can’t test that but it should work.

couldn’t test no-detach cause I don’t have a PC on me rn. Again it should work

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@Lockl00p Lockl00p requested a review from Derisis13 as a code owner August 23, 2024 15:15
@Lockl00p Lockl00p changed the title Fix issue where a non-working Alt link gets used when on iSH fix: fix issue where a non-working Alt link gets used when on iSH Aug 23, 2024
@port19x
Copy link
Collaborator

port19x commented Aug 23, 2024

Quite odd indeed, will test later

@port19x port19x linked an issue Aug 23, 2024 that may be closed by this pull request
@port19x port19x merged commit 4b735c6 into pystardust:master Aug 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No video playback in VLC (IOS)
2 participants