feat: added flag for mpv as flatpak

[Derisis13]

Pull Request Template

Type of change

• Bug fix
• Feature
• Documentation update

Description

Comply with request #1408

Checklist

• any anime playing
• bumped version

---

• next, prev and replay work
• -c history and continue work
• -d downloads work
• -s syncplay works
• -q quality works
• -v vlc works
• -e select episode works
• -S select index works
• -r range selection works
• --skip ani-skip works
• --skip-title ani-skip title argument works
• --no-detach no detach works
• --dub and regular (sub) mode both work
• all providers return links (not necessarily on a single anime, use debug mode to confirm)

---

• -h help info is up to date
• Readme is up to date
• Man page is up to date

Additional Testcases

• The safe bet: One Piece
• Episode 0: Saenai Heroine no Sodatekata ♭
• Unicode: Saenai Heroine no Sodatekata ♭
• Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

[port19x]

Didn't we already have that at some point?

[Derisis13]

Didn't we already have that at some point?

We may have. But it seems like there's a need for this. I see no reason why we shouldn't have it.

[port19x]

Because we already have a flatpak_mpv player for steamdeck implemented.
I'd rather have player detection fall back to flatpack mpv when a regular mpv can't be detected.
A similar pattern to what I want is already used for iina, where manually installed iina needs different handling than iina installed via homebrew

[port19x]

This would have the additional upside of consolidating case branches with steamdeck

[Derisis13]

Ok, can do. It makes sense not to not trust it onto our users to know which package format they use

[port19x]

This part is actually not necessary, since dep_ch will already exit

[Derisis13]

I tested it, it doesn't.

[Derisis13]

I've tested what I could on linux, but @ykhan21 I'd like you to test it on windows if it correctly detects installed and uninstalled mpv, and @Nannk to check it on the steamdeck if it still finds the flatpak version.
Also @port19x I think there's a little issue with where_iina() which I couldn't test: when the subshell exits, the main program continues uninterrupted. I suggest to use a similar structure like I did with where_mpv()

[port19x]

iirc it worked fine in my testing on mac os. return exits subshells, exit always aborts the shell script.

SO Post

Where is this not the case?

[port19x]

Could it be because you use a default assignment? ${ANI_CLI_PLAYER:-$(where_mpv)}

In where iina, that is checked within the function, but I'd be surprised if that changes things

[Derisis13]

iirc it worked fine in my testing on mac os. return exits subshells, exit always aborts the shell script.

SO Post

Where is this not the case?

Linux and dash. Same if the default assignment is not present, like with iina.

[Derisis13]

And checking the shell specification's related section reveals that exit only returns from the current subshell and continues from the environment it was called from.

[port19x]

Alright, I'm taking the L

[Derisis13]

Now then why haven't the two remaining checks ran?

[port19x]

Now then why haven't the two remaining checks ran?

I have no idea. I added the completion files to path ignore, but you haven't changed those in this PR, so I'm surprised they aren't running. Github Actions is a bit fragile at times.

Wanna patch my where_iina to be more in line with your where_mpv?

Let's see if github wakes from its slumber after another commit

[Derisis13]

Wanna patch my where_iina to be more in line with your where_mpv?

Sure, let's see

[port19x]

How odd. Could it be that I have misunderstood how the filtering works in github actions?

[port19x]

Now that's a surprise. Perhaps a brown out on githubs part to bully people into migrating away from a deprecated nodejs version (used by checkout v3)