-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tab-completion for zsh and bash #1419
Conversation
Bash completion would be nice |
I'll work on that tomorrow, if I got time. |
Also, I'd prefer to have the completion data separate file that people can install as you show in your screenshot |
Otherwise this looks good |
The idea was tho add options for every shell that is gonna be implemented for it.
Didn't add the last part since I just tried it with zsh for a start. |
Now it should work for bash and zsh.
detects the shell automatically |
The problem I have with this is that the script gets bloated 120 lines for a glorified print. Please make these things separate files in the repo and document their use in the README |
I have 2 options for you here. One where you just need to execute the script and another one that requires you to move and source the completion file one your own. Which should it be? |
Thanks, I prefer the manual way. |
Okay then I'll edit it according to that. No I copied them from the original script and it just happens to be the case that nvim pastes under and not on the line you are on. And one more thing... how are the people that use their package manager to install ani-cli use this now? |
I mean without doing an extra step and downloading from github anyway |
Packagers could work around this, or they would need to fetch the completion info manually. I believe this is fine, because the people that would see |
Hope that it's to your liking now @port19x ! |
Thanks for the contribution |
This completion option is for zsh only at the moment, if you like what you see or have suggestions for what other shells I should make it for tell me and I'll do my best.
Really enjoying the tool itself btw 💜