Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : link parsing problems and reduce curl call for majority of animes #544

Merged
merged 1 commit into from
Feb 20, 2022
Merged

fix : link parsing problems and reduce curl call for majority of animes #544

merged 1 commit into from
Feb 20, 2022

Conversation

RaynardGerraldo
Copy link
Contributor

fix #515 #542

@RaynardGerraldo RaynardGerraldo linked an issue Feb 19, 2022 that may be closed by this pull request
Irregular Behaviour during Download #542
Closed
@RaynardGerraldo RaynardGerraldo added category: url url changes or extraction problems type: bug something isn't working type: enhancement (depreceated) improvements to an existing feature labels Feb 19, 2022
Derisis13
Derisis13 requested changes Feb 19, 2022
View reviewed changes
Copy link
Collaborator

@Derisis13 Derisis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces on every single line, please change them to tabs. Also according to our current style guideline, do should be in the same row as for, just like if and then. I would also consider making the if ! ... then into a ||, if that makes sense for you. Otherwise looking good!

@71zenith 71zenith requested a review from Derisis13 February 19, 2022 15:50
@RaynardGerraldo
Copy link
Contributor Author

Spaces on every single line, please change them to tabs. Also according to our current style guideline, do should be in the same row as for, just like if and then. I would also consider making the if ! ... then into a ||, if that makes sense for you. Otherwise looking good!

sorry bout that thanks for the review ,and thanks for the help @71zenith

@CoolnsX
Copy link
Collaborator

CoolnsX commented Feb 19, 2022

@71zenith can u put -x 16 -s 16 in line 446.. and remove commented lines above it...

@71zenith
Copy link
Collaborator

71zenith commented Feb 19, 2022 •
edited by CoolnsX
Loading

sure, but what shall be the commit message

some optimization.. ig

@71zenith
Copy link
Collaborator

tell before merging, we have to squash the commits

Derisis13
Derisis13 approved these changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@Derisis13 Derisis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
@Zenith71 you requested a reminder to squash

@Derisis13
Copy link
Collaborator

Although line 159 should be part of line 158...

@RaynardGerraldo
Copy link
Contributor Author

Although line 159 should be part of line 158...

@Derisis13 good?

@RaynardGerraldo @71zenith
fix: (#542) and (#515)
54169b8 
* refactor: slightly fasten up script for majority of animes

* chore: version bump 1.8.0 -> 1.8.1

* style: spaces -> tabs

* refactor: change single condition if-else statement to one-liner

* refactor: optimize aria2c

* refactor: remove unused case arm

* refactor: move do statement to for loop row

* docs: remove make as dependency for termux
@Derisis13
Copy link
Collaborator

Although line 159 should be part of line 158...

@Derisis13 good?

Perfect

@71zenith 71zenith merged commit fa3f545 into pystardust:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@71zenith 71zenith 71zenith approved these changes

@Derisis13 Derisis13 Derisis13 approved these changes

Assignees
No one assigned
Labels
category: url url changes or extraction problems type: bug something isn't working type: enhancement (depreceated) improvements to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Irregular Behaviour during Download Unable to view an episode
4 participants
@RaynardGerraldo @CoolnsX @71zenith @Derisis13