Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init(PULL_REQUEST_TEMPLATE.md) #695

Merged
merged 6 commits into from
Apr 30, 2022
Merged

init(PULL_REQUEST_TEMPLATE.md) #695

merged 6 commits into from
Apr 30, 2022

Conversation

justchokingaround
Copy link
Collaborator

this is just an early draft, don't merge this yet
#693

@CoolnsX CoolnsX linked an issue Apr 29, 2022 that may be closed by this pull request
Audio only on MPV #691
Closed
Derisis13
Derisis13 reviewed Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@Derisis13 Derisis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the innitiative, but do we want the testing to be part of the PR template?

@port19x
Copy link
Collaborator

port19x commented Apr 29, 2022

I like the innitiative, but do we want the testing to be part of the PR template?

Yes, to function as sort of a checklist

@port19x
Copy link
Collaborator

port19x commented Apr 29, 2022

Don't like the template as it is now, will do some work on the branch later today

@port19x port19x linked an issue Apr 29, 2022 that may be closed by this pull request
Let's make a pull request template #693
Closed
port19x
port19x reviewed Apr 29, 2022
View reviewed changes
ani-cli
idx="$links_count"
idx="auto"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the thing that fixes the mpv audio only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this the only use of links_count? If yes, we should remove it's assignment as well

Copy link
Collaborator

@CoolnsX CoolnsX Apr 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require that links count for if condition checking as if user gives out of range index then it will fall back to default, so...
However we can reduce it by merging both m3u8_links and links_count variable

PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@port19x port19x requested a review from Derisis13 April 30, 2022 09:30
@port19x
Copy link
Collaborator

port19x commented Apr 30, 2022

I have moved testing from contributing.md into the PR template.
I'd also consider a checkbox for cryptographic key changes

@port19x port19x merged commit f7d65fd into master Apr 30, 2022
@port19x port19x deleted the pr-template branch April 30, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoolnsX CoolnsX CoolnsX left review comments

@port19x port19x port19x approved these changes

@Derisis13 Derisis13 Awaiting requested review from Derisis13 Derisis13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's make a pull request template Audio only on MPV
4 participants
@justchokingaround @port19x @Derisis13 @CoolnsX