Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PPA install instructions to README #793

Merged
merged 14 commits into from
Aug 19, 2022
Merged

Conversation

Wiener234
Copy link
Contributor

@Wiener234 Wiener234 commented Jun 24, 2022

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

*I build a debian package and it is hosted in this PPA "https://github.com/Wiener234/ani-cli-ppa".

I added the install instructions with the GPG Key to the README under the Debian section with.*

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • quality works
  • downloads work
  • quality works with downloads
  • select episode -a and rapid resume work
  • syncplay -s works
  • autoplay, aka range selection, works

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Not uploaded: one piece dub episode 590
  • Unreleased: soredemo ayumu wa yosetekuru
  • Short id (for decryption): Log Horizon episode 1-2

Derisis13 and others added 4 commits June 22, 2022 13:18
Under the Linux install option I added the instructions for adding the PPA for Debian
it now uses wget and not die depricated apt-key
@Derisis13
Copy link
Collaborator

I'll close #789 in favour of this. I'll also write a full guide for rpm, and I'd like to see similar ones for the AUR, termux, scoop and brew (at least)

@Derisis13
Copy link
Collaborator

This is what I could find. Instructions for brew are missing from v2.2's readme and I can't get my head around the scoop instructions + I'm not even sure if it'd work...

README.md Show resolved Hide resolved
README.md Outdated
Comment on lines 97 to 98
To install mpv (and vlc) you need _RPM Fusion free_ enabled. Simply follow the instructions here: https://rpmfusion.org/Configuration
To be able to install syncplay, you'll need to enable this copr repo: https://copr.fedorainfracloud.org/coprs/batmanfeynman/syncplay/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary information?

README.md Outdated
To install mpv (and vlc) you need _RPM Fusion free_ enabled. Simply follow the instructions here: https://rpmfusion.org/Configuration
To be able to install syncplay, you'll need to enable this copr repo: https://copr.fedorainfracloud.org/coprs/batmanfeynman/syncplay/

There are currently two packages for Fedora: `ani-cli` which is a minimal installation that can only use mpv and `ani-cli-full` which contains all the functionality (note that vlc and syncplay are still optional dependencies).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why/how?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have two packages, only one that has it all.

README.md Outdated
yay -S ani-cli
```

### Installing from source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe give nix os a section too, they have a package thats well maintained iirc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Do we know who the nixpkg maintainer is?

now includes install command
@port19x
Copy link
Collaborator

port19x commented Aug 10, 2022

Can we port this PR to include recent readme changes?
I do find ppa & copr instructions valuable

@Derisis13
Copy link
Collaborator

I'll try to work on this. I'd also like scoop added too, since it's once again maintained

Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mergable too me.
Suitable merge commit message: docs: more distrospecific instructions
I'll wait for another sign off

@Derisis13 Derisis13 merged commit 24f5477 into pystardust:master Aug 19, 2022
@Wiener234 Wiener234 deleted the add-ppa branch January 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants