Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implprefix arg to PluginManager #145

Closed
goodboy opened this issue May 18, 2018 · 0 comments · Fixed by #271
Closed

Remove implprefix arg to PluginManager #145

goodboy opened this issue May 18, 2018 · 0 comments · Fixed by #271

Comments

@goodboy
Copy link
Contributor

goodboy commented May 18, 2018

As per discussion in #144 we plan to outright remove the implprefix kwarg to PluginManager after an appropriate PR has been made to pytest implementing the prefix based hook detection/registration.

Further discussion should be made here regarding a possible strategy pattern for hook detection outside of the regular explicit marking mechanism.

An initial thought is to instead offer prefix based registration through a prefix kwarg to PluginManager.register() if this is a feature we'd like to keep.

goodboy pushed a commit to goodboy/pytest that referenced this issue May 18, 2018
`pluggy` is deprecating the `implprefix` argument in the next major
release so implement this detection in our derived plugin manager.

Relates to pytest-dev/pluggy#145
goodboy pushed a commit to goodboy/pytest that referenced this issue May 18, 2018
`pluggy` is deprecating the `implprefix` argument in the next major
release so implement this detection in our derived plugin manager.

Relates to pytest-dev/pluggy#145
@goodboy goodboy added this to the 1.0 milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant