Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logo #40

Closed
goodboy opened this issue Jan 31, 2017 · 6 comments
Closed

Add a logo #40

goodboy opened this issue Jan 31, 2017 · 6 comments

Comments

@goodboy
Copy link
Contributor

goodboy commented Jan 31, 2017

I think I found a good one using a plug symbol and we should be able to insert it using the built-in sidebarlogo in the layout.html sphinx-template.
@nicoddemus
Copy link
Member

Can you show a preview somewhere? 😁

@nicoddemus
Copy link
Member

(Only the logo, I mean)

@goodboy
Copy link
Contributor Author

goodboy commented Feb 1, 2017

@nicoddemus I had this in mind :)
plug

@nicoddemus
Copy link
Member

I like it. 👍

If nobody manifests against it, I suggest to just add it to your PR. It is nice to have a logo initially and it is easy to change it later.

@hpk42
Copy link
Contributor

hpk42 commented Feb 1, 2017

i'd like it as initial logo modulo one change request: strip the left "wire", this also makes it a bit more quadratic which is useful.

@goodboy
Copy link
Contributor Author

goodboy commented Feb 3, 2017

@hpk42 Ok i'll see what i can do.
I may make a separate PR to get this in if you guys don't mind?

goodboy pushed a commit to goodboy/pluggy that referenced this issue Feb 5, 2017
Add a plug logo
1b40531 
Resolves pytest-dev#40
@hpk42 hpk42 closed this as completed in 04d7b29 Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hpk42 @goodboy @nicoddemus