Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger a deprecationwarning for Result.excinfo #86

Closed
RonnyPfannschmidt opened this issue Sep 10, 2017 · 7 comments
Closed

trigger a deprecationwarning for Result.excinfo #86

RonnyPfannschmidt opened this issue Sep 10, 2017 · 7 comments
Assignees

Comments

@RonnyPfannschmidt
Copy link
Member

pluggy/pluggy/callers.py

Lines 32 to 34 in 1037dc9

@property
def excinfo(self):
return self._excinfo

we kept the code for pytest, but we should at least deprecate it and remove the use in future

@goodboy
Copy link
Contributor

goodboy commented Sep 11, 2017

@RonnyPfannschmidt works for me.

@goodboy goodboy mentioned this issue May 23, 2018
@goodboy
Copy link
Contributor

goodboy commented May 24, 2018

@RonnyPfannschmidt wait so we don't want to allow for public access at all?
Is the idea that users can catch the underlying exception instead from get_result()?

@RonnyPfannschmidt
Copy link
Member Author

correct

goodboy pushed a commit to goodboy/pluggy that referenced this issue May 24, 2018
goodboy pushed a commit to goodboy/pluggy that referenced this issue May 25, 2018
goodboy pushed a commit to goodboy/pluggy that referenced this issue May 27, 2018
goodboy pushed a commit to goodboy/pluggy that referenced this issue Jul 26, 2018
@goodboy
Copy link
Contributor

goodboy commented Jan 2, 2019

@RonnyPfannschmidt waiting on you still as per your #155 comment as to how to move forward with an alternative system for this.

@RonnyPfannschmidt
Copy link
Member Author

@tgoodlet thanks for the reminder, i still haven't come up with a reasonable failure indication system, i believe this will require a little collaborative brainstorming to generate ideas

@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Jan 2, 2019
@nicoddemus
Copy link
Member

What was the rationale for not exposing the exception object again?

@RonnyPfannschmidt
Copy link
Member Author

closing this one as it will disappear with the deprecation/removal of result objects in #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants