-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 2.6 & 3.3 #103
Conversation
@hugovk looks good 👍 Do you mind tagging your commit message with |
I certainly can do, but "Fixes #92" in the PR message should do the same: https://help.github.com/articles/closing-issues-using-keywords/ Would you like the commit message updating? Edit: here's a test that shows a PR message closing an issue: hugovk/test#12 |
@hugovk also please add a new CHANGELOG entry, I think the next version should be |
CHANGELOG updated. Should we also drop EOL Python 3.3? 3.3 was dropped from pytest's features branch at the same time as 2.6: pytest-dev/pytest#2822. |
Cool, then I don't care too much if it's git history.
I'm 👍 on this but wait to see what @nicoddemus and @RonnyPfannschmidt say. |
Yes please. 😁 |
Updated to drop 3.3 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hugovk!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Fixes #92.