Test historic hook with no callback #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just redid @rmfitzpatrick's fix from #110 here since that PR was prior to the module split and conflicts. |
added 2 commits
January 10, 2018 01:22
Ensure that if a result callback (dubbed `proc` for the moment) provided to `PluginManager.call_historic()` is `None`, no error occurs. Relates to pytest-dev#110
Thanks to @rmfitzpatrick for this fix!
goodboy
force-pushed
the
test_proc_is_none
branch
from
eeef0aa to
dcde058
Compare
|
Sorry for losing sight of this. Thanks for the fix! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test requested for #110 since @rmfitzpatrick seems to be MIA.
Added the fix from that PR here.