Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor fixes #224

Merged
merged 4 commits into from
Jul 24, 2019
Merged

A few minor fixes #224

merged 4 commits into from
Jul 24, 2019

Commits on Jul 21, 2019

  1. Configuration menu
    Copy the full SHA
    b2ffeb9 View commit details
    Browse the repository at this point in the history
  2. Don't confusingly reuse a variable name inside varnames()

    `defaults` is the default values e.g. `1` in `foo=1`. It's just used to
    find the offset of the kwargs, but the code reused the name which made
    me scratch my head for a minute.
    bluetech committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    92c31e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Remove broken test

    The test passes invalid values to the instance (it does not takes
    functions, it takes HookImpls). The test fails, but it accidentally used
    `return` instead of `assert` so it wasn't visible.
    
    Since what is being tested is evidently unimportant and legacy, just
    remove it.
    bluetech committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    0194e63 View commit details
    Browse the repository at this point in the history
  2. Fix call_historic() example in index.rst

    It doesn't take `**kwargs` but an argument `kwargs`.
    bluetech committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    95dd65f View commit details
    Browse the repository at this point in the history