Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some steps towards exporting our typings #429

Merged
merged 7 commits into from
Aug 12, 2023
Merged

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Aug 5, 2023

Handles some items from #428, but not finished yet.

By default <2 is used, but we want to use new features.

Refs pytest-dev#428
So it doesn't overflow to the content. Probably there's a better fix for
this.
For typing purposes, refs pytest-dev#428.

The old name `pluggy._result._Result` is kept for backward
compatibility, no reason to break the "offenders" who have imported it
before.
For typing purposes, refs pytest-dev#428.

The old name `pluggy._hooks._HookCaller` is kept for backward
compatibility, no reason to break the "offenders" who have imported it
before.
For typing purposes, refs pytest-dev#428.

The old name `pluggy._hooks._HookRelay` is kept for backward
compatibility, no reason to break the "offenders" who have imported it
before.
@bluetech
Copy link
Member Author

bluetech commented Aug 5, 2023

Note: I will add a changelog entry detailing all of the changes once I'm finished with the issue.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

"""Hook holder object for performing 1:N hook calls where N is the number
of registered plugins."""

__slots__ = ("__dict__",)

def __init__(self) -> None:
""":meta private:"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@bluetech bluetech merged commit 475c4aa into pytest-dev:main Aug 12, 2023
13 of 15 checks passed
@bluetech bluetech deleted the typing2 branch August 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants