-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check marker arguments #886
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 91.86% 91.50% -0.37%
==========================================
Files 2 2
Lines 504 506 +2
Branches 99 100 +1
==========================================
Hits 463 463
- Misses 24 25 +1
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. |
e2bd784
to
c59e2b9
Compare
docs: Added changelog entry for error for positional asyncio marker arguments.
deecec7
to
db7a1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
I rebased the code to main and adjusted the tests to use the new loop_scope kwargs rather than the deprecated scope kwarg to @pytest.mark.asyncio
.
I also added a changelog entry.
As this error is thrown at every unrecognized keyword argument, could it be improved to something more generic, please? |
@MeggyCal What problem are you encountering and what improvement do you suggest to solve it? |
Hi, I've been debugging redis/redis-py#3339 lately. I find |
This PR implements error checking for the arguments of
mark.asyncio
.An ValueError with a helpful message is raised when unexpected arguments are passed.
This should fix issue #812.