Dont adjust the value of DEBUG_PROPAGATE_EXEPTIONS #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is indeed strange, Django doesn't change this setting for its test runs, so there is no reason we should do so either! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin shouldn't make assumptions like this about an environment. This explicitly causes many tests to fail (that are integration tests) in the sentry client bindings (which hooks into Django exception signals), and is pretty painful to fix at a global level.
Unless there's a really good reason this is being forced, we should leave it up to the enduser to decide if they need it enabled or not.