Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-introduced auto clearing of mail.outbox #434

Merged

Conversation

peterlauri
Copy link
Contributor

Closes #433

@pelme
Copy link
Member

pelme commented Nov 24, 2016

Thank you!

Wouldn't replacing mail.outbox like this be a regression from the fix in #407?

@peterlauri peterlauri force-pushed the 433_bring_back_mailbox_clearing branch from 242c3fb to b868320 Compare November 24, 2016 07:53
@peterlauri
Copy link
Contributor Author

@pelme so true, fixed that and squashed...

@pelme
Copy link
Member

pelme commented Nov 24, 2016

Sorry to not noticed the first time around, but is the monkeypatch in mailoutbox really necessary now? Wouldn't just return mail.outbox be enough?

@peterlauri peterlauri force-pushed the 433_bring_back_mailbox_clearing branch from b868320 to 4d3a545 Compare November 24, 2016 08:01
@peterlauri
Copy link
Contributor Author

@pelme so true again, fix and squash... But now there is no code to maintain anymore... :(

@pelme pelme merged commit 7aee367 into pytest-dev:master Nov 24, 2016
@pelme
Copy link
Member

pelme commented Nov 24, 2016

Excellent :D

@peterlauri peterlauri deleted the 433_bring_back_mailbox_clearing branch November 24, 2016 08:04
mfa pushed a commit to aexeagmbh/pytest-django that referenced this pull request May 17, 2017
timb07 pushed a commit to timb07/pytest-django that referenced this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants