Improve --fail-on-template-vars: use origin if available #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Apr 17, 2017
This will be there with Django 1.9+ always, and in case of `settings.TEMPLATE_DEBUG` before. It stops going up to the Template, but uses the nearest location (which is required when extending templates). Using `django.template.base.Origin` also gives the benefit of having the full/absolute path.
blueyed
force-pushed
the
invalid-template-var-origin
branch
from
c428f59
to
369e519
Compare
|
Thanks for the review, squashed into two commits now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be there with Django 1.9+ always, and in case of
settings.TEMPLATE_DEBUGbefore. It also not go up to the Template,but uses the nearest location (which is required with extending
templates).
Using
django.template.base.Originalso gives the benefit of having thefull/absolute path.
btw: I suggested to not throw it with the
defaultfilter in Django in django/django#8200 - we might add it in pytest-django already / instead (if it gets not accepted in Django).