ci: introduce mypy to the project #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youtux
reviewed
May 2, 2022
|
If it gives less headaches, we can use pyright instead of mypy |
skarzi
changed the title
skarzi
force-pushed
the
feature/introduce-mypy-and-isort
branch
from
773f7b5
to
5f92690
Compare
youtux
requested changes
May 4, 2022
youtux
reviewed
May 4, 2022
youtux
reviewed
May 4, 2022
youtux
reviewed
May 4, 2022
|
I notified mypy developers of the issue we have in CI with the call to |
youtux
reviewed
May 5, 2022
pytest_factoryboy/fixture.py
Outdated
| @@ -191,7 +191,7 @@ def inject_into_caller(name: str, function: Callable, locals_: dict[str, Any]) - | |||
| # Therefore, we can just check for __qualname__ to figure out if we are in a class, and apply the @staticmethod. | |||
| is_class_or_function = "__qualname__" in locals_ | |||
| if is_class_or_function: | |||
| function = staticmethod(function) | |||
| function = staticmethod(function) # type: ignore[assignment] | |||
There was a problem hiding this comment.
since the build is now failing because of a bug of mypy and this line, I would say to remove the type: ignore[assignment] from here, and change the mypy builds to do a "ignore_outcome = true" so that we won't block on a failure on mypy for now.
youtux
reviewed
May 5, 2022
youtux
approved these changes
May 6, 2022
|
Thank you @skarzi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft and before merging it following things need to be done:
mypyconfiguration