Add mypy to CI #177
Merged
Add mypy to CI #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR #176 adjusted GitHub CI to run against latest python versions, but the tox configuration does not respect this change. This commit updates the tox as well.
nicoddemus
reviewed
Oct 30, 2023
| @@ -1,6 +1,6 @@ | |||
| [tox] | |||
| envlist = | |||
| py{37,38,39,linting} | |||
| py{38,39,310,311,312,linting},mypy | |||
There was a problem hiding this comment.
Note that this mypy environment is not running in CI.
I suggest actually that we run mypy in CI by configuring it in .pre-commit-config.yaml instead. Here's how pytest does it:
There was a problem hiding this comment.
Good catch @nicoddemus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR provides some type hints (as per #176) and adjusts GitHub CI to respect them.
toxtoxconfiguration was updated to keep python envs consistent with GitHub CI (py37 was dropped, py311 and py312 were added)Checklist:
docs/CHANGELOG.rst, summarizing the change and linking to the issue.pre-commithooks and fix any issues.pytestand make sure no tests failed.