Fix some typos and conform to PEP 8 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump |
|
Hi, @allanlewis! I'll review your changes in this weekend. Thank you for patience. |
nicoddemus
reviewed
Mar 29, 2017
| @@ -6,8 +6,9 @@ | |||
| import socket | |||
|
|
|||
| try: | |||
| from urllib2 import urlopen | |||
| from urllib2 import URLError, urlopen | |||
There was a problem hiding this comment.
A suggestion: instead of falling back on an ImportError, you might consider explicitly testing the python version using sys.version_info and use the correct imports for that version: I had problems in the past were this technique caused an import error in Python 3 for different reasons to give a confusing warning because of the fallback (pytest-dev/pytest-mock#68).
(I understand the code was already like this before but thought I would mention it anyway).
nicoddemus
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.