Skip to content

Commit

Permalink
Fix deployment workflow (#358)
Browse files Browse the repository at this point in the history
* Set SETUPTOOLS_SCM_PRETEND_VERSION so we build the package with the correct version.
* Update gh-action-pypi-publish to latest version
* Update RELEASING with new instructions
  • Loading branch information
nicoddemus authored Apr 21, 2023
1 parent 5068287 commit c778ee7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
environment: deploy
permissions:
id-token: write # For PyPI trusted publishers.
env:
SETUPTOOLS_SCM_PRETEND_VERSION: ${{ github.event.inputs.version }}

steps:
- uses: actions/checkout@v3
Expand All @@ -29,7 +31,7 @@ jobs:
path: dist

- name: Publish package to PyPI
uses: pypa/gh-action-pypi-publish@master
uses: pypa/gh-action-pypi-publish@v1.8.5

- uses: actions-ecosystem/action-push-tag@v1
with:
Expand Down
6 changes: 3 additions & 3 deletions RELEASING.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Here are the steps on how to make a new release.

1. Create a ``release-VERSION`` branch from ``upstream/master``.
1. Create a ``release-VERSION`` branch from ``upstream/main``.
2. Update ``CHANGELOG.rst``.
3. Push a branch with the changes.
4. Once all builds pass, run the ``deploy`` workflow manually.
3. Push the branch to ``upstream``.
4. Once all tests pass, start the ``deploy`` workflow manually.
5. Merge the PR.

0 comments on commit c778ee7

Please sign in to comment.