Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocker for class, module, package and session scopes #182

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

scorphus
Copy link
Contributor

While the feature proposed in pytest-dev/pytest#1681 is interesting and would serve as a base for a more elegant solution to #136, adding those supplementary mockers allows this plugin to be used in other scopes.

Fix #136

While the feature proposed in pytest-dev/pytest#1681 is interesting and
would serve as a base for a more elegant solution to pytest-dev#136, adding those
supplementary mockers allows this plugin to be used in other scopes.

Fix pytest-dev#136
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scorphus, sorry for the delay!

Thanks for the complete patch, really appreciate it. 👍

@nicoddemus nicoddemus merged commit e43552a into pytest-dev:master Apr 18, 2020
@scorphus scorphus deleted the scoped-mockers branch April 18, 2020 22:36
@scorphus
Copy link
Contributor Author

My pleasure to contribute to this super useful package! Thanks for making it available, for taking the time to review and accept this PR and for drafting a new release! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mocker fixture cannot be used in module scope
2 participants