Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type improvements #201

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Aug 24, 2020

  • Annotate MockerFixture.patch(). Without an explicit annotations, mypy and other type checkers can't determine the proper type and assume Any.
  • MockerFixture.patch() can return an arbitrary type if either new or new_callable is provided. Add overloads to handle these cases.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @srittau, indeed I missed those.

Annotate MockerFixture.patch(). Without an explicit annotations, mypy
and other type checkers can't determine the proper type and assume Any.

MockerFixture.patch() can return an arbitrary type if either new or
new_callable is provided. Add overloads to handle these cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants