Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert_has_calls_wrapper #359

Closed
wants to merge 2 commits into from
Closed

Conversation

Astral1020
Copy link
Contributor

@Astral1020 Astral1020 commented Apr 24, 2023

For this issue #234

image

@Astral1020
Copy link
Contributor Author

@nicoddemus Do you have time to take a look?

@nicoddemus
Copy link
Member

Hi @Astral1020,

Yes, thanks a lot for the contribution!

I did take a glance at the implementation, will take a better look later today. Meanwhile, could you add one or more tests to cover the new function? Thanks!

@acovaci
Copy link
Contributor

acovaci commented Jun 14, 2023

Added unit tests in #365, couldn't figure out how to commit to this :((

@nicoddemus
Copy link
Member

Superseded by #365, thanks @Astral1020!

@Astral1020
Copy link
Contributor Author

@nicoddemus Sorry I miss the notification, and thank you for keep my commit.

@nicoddemus
Copy link
Member

Sure thing, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants