Stop importing from py #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
py._code has been moved to _pytest._code with pytest 2.9.0: https://docs.pytest.org/en/latest/changelog.html#id395 We still imported from py._code without actually depending from py. While this happened to work, it now breaks due to pytest dropping py: pytest-dev/pytest#10396 Resulting in: File ".../src/pytestqt/logging.py", line 5, in <module> from py._code.code import TerminalRepr, ReprFileLocation ModuleNotFoundError: No module named 'py._code'; 'py' is not a package with the latest pytest main.
nicoddemus
approved these changes
Oct 25, 2022
|
Thanks! |
|
Thank you for the quick merge! I assume you're planning to cut a new release after the currently open PRs are in? |
|
Yep! |
|
Thanks for the quick fix! I just discovered this error now and was investigating. And thanks for making the release so fast. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py._code has been moved to _pytest._code with pytest 2.9.0: https://docs.pytest.org/en/latest/changelog.html#id395
We still imported from py._code without actually depending from py. While this happened to work, it now breaks due to pytest dropping py: pytest-dev/pytest#10396
Resulting in:
with the latest pytest main.