Add faker and faker_seed fixtures support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged and released in version 3.4.0, thanks! Next time you make an open source contribution please check for the things I added/fixed - a changelog note, documentation changes, and passing the tests on CI. |
|
@adamchainz Thank you very much for your quick review, fixes and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faker offers both
fakerandfaker_seedfixtures.The problem is that using only the
fakerfixture simply ignorespytest-randomly's seed.The documented way of seeding the
fakerfixture mentions usingfaker_seed.This PR is a proposal to make
pytest-randomlyprovide its seed tofakerviafaker_seed.