Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work around ResultLog support for pytest>=6.1 #129

Merged
merged 4 commits into from
Sep 28, 2020
Merged

work around ResultLog support for pytest>=6.1 #129

merged 4 commits into from
Sep 28, 2020

Conversation

ntessore
Copy link
Contributor

This is a workaround that closes #128. It does not address potential integration with the reportlog plugin.

gnikonorov
gnikonorov approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@gnikonorov gnikonorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an immediate fix to stop the fatal error, I think this is OK. I will defer to @sallner and/or @icemac for the merge.

@ntessore if this gets merged can you open a separate issue to track integration with reportlog so it doesn't get lost?

@gnikonorov gnikonorov added the maintenance Keep up with the current pytest releases. label Sep 27, 2020
@gnikonorov
Copy link
Member

Could you also add a changelog entry to this PR, @ntessore? It can be added in the CHANGES.rst file

@Hanke98 Hanke98 mentioned this pull request Sep 27, 2020
Open
@ntessore
Copy link
Contributor Author

@gnikonorov I'm really not qualified to open an issue on pytest plugin interoperability, I wouldn't even know if that should be an issue here or in pytest-dev/pytest-reportlog.

gnikonorov
gnikonorov requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@gnikonorov gnikonorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpickish comment on the changelog text

CHANGES.rst Outdated Show resolved Hide resolved
@gnikonorov
Copy link
Member

@gnikonorov I'm really not qualified to open an issue on pytest plugin interoperability, I wouldn't even know if that should be an issue here or in pytest-dev/pytest-reportlog.

@ntessore I'll open one then. Thank you for fixing the crash

@gnikonorov gnikonorov mentioned this pull request Sep 28, 2020
Open
icemac
icemac reviewed Sep 28, 2020
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Sep 28, 2020
@The-Compiler
Pin pytest to < 6.1
cd76e03 
See pytest-dev/pytest-rerunfailures#128
and pytest-dev/pytest-rerunfailures#129
@sallner
Copy link
Member

sallner commented Sep 28, 2020

I am unhappy with the fact, that we have now 3 ways of handling the resultlog in this plugin, but it seems that a bugfix release might be appropriate to make various CIs green again.

sallner
sallner approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge the changes and cut a release as 9.1.1. We can clean up the rest afterwards.

@sallner sallner merged commit 04b5e9c into pytest-dev:master Sep 28, 2020
@ntessore ntessore deleted the remove-resultlog branch September 28, 2020 14:34
@tfoote tfoote mentioned this pull request Sep 28, 2020
Closed
@icemac
Copy link
Contributor

icemac commented Sep 29, 2020

I will merge the changes and cut a release as 9.1.1. We can clean up the rest afterwards.

Maybe it should become a 9.2 or even 10.0 as the --result-log command line option is no linger supported when this plug-in is used together with pytest >= 6.1.

@sallner
Copy link
Member

sallner commented Sep 29, 2020

@ntessore Thanks for the work, version 9.1.1 is out with the workaround. https://pypi.org/project/pytest-rerunfailures/9.1.1/ Let's see, what we will do with the clean up, and if we need to support resultlog in the future.

@hugovk
Copy link
Member

hugovk commented Sep 29, 2020

Thank you all for the quick fix and release!

@tfoote tfoote mentioned this pull request Sep 29, 2020
Merged
@sackh sackh mentioned this pull request Sep 29, 2020
Merged
nabobalis added a commit to sunpy/sunpy that referenced this pull request Oct 5, 2020
@nabobalis
removed pytest pin
888a9d3 
Fixed up stream: pytest-dev/pytest-rerunfailures#129
@nabobalis nabobalis mentioned this pull request Oct 5, 2020
Merged
pabs3 added a commit to pabs3/gensim that referenced this pull request Nov 7, 2021
@pabs3
Enable pytest-rerunfailures test dependency again
5bca10c 
pytest-rerunfailures is now compatible with pytest 6.1.0 and later.

Reverts: commit 8687e7f.
Reported-in: pytest-dev/pytest-rerunfailures#128
Fixed-by: pytest-dev/pytest-rerunfailures#129
@pabs3 pabs3 mentioned this pull request Nov 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac left review comments

@gnikonorov gnikonorov gnikonorov requested changes

@sallner sallner sallner approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
maintenance Keep up with the current pytest releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_pytest.resultlog was removed in pytest 6.1.0
6 participants
@ntessore @gnikonorov @sallner @icemac @hugovk @nicoddemus