Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #239 #240

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix Issue #239 #240

merged 1 commit into from
Nov 22, 2023

Conversation

metheuspsc
Copy link
Contributor

Fixes issue #239 and adds test coverage

@icemac
Copy link
Contributor

icemac commented Nov 10, 2023

@metheuspsc Thank you for your contribution. Could you please undo the code formatting changes? This Project uses black to format the code which has its own strong opinion how to format the code, see https://github.com/pytest-dev/pytest-rerunfailures/actions/runs/6590126996/job/18552878766?pr=240 for details.

@icemac icemac assigned icemac and metheuspsc and unassigned icemac Nov 10, 2023
@icemac icemac self-requested a review November 10, 2023 07:16
@metheuspsc
Copy link
Contributor Author

@icemac issues fixed!

@icemac
Copy link
Contributor

icemac commented Nov 16, 2023

Currently flake8 crashes, let me update the pre-commit config in a separate PR.

@icemac
Copy link
Contributor

icemac commented Nov 17, 2023

@metheuspsc Could you please rebase your branch onto the current master branch, so the flake8 crash hopefully gets fixed?

@metheuspsc
Copy link
Contributor Author

Rebased!

@icemac icemac merged commit 1765772 into pytest-dev:master Nov 22, 2023
45 checks passed
@icemac
Copy link
Contributor

icemac commented Nov 22, 2023

Thank you for this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants