-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure for readthedocs #284
Conversation
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
I recommend wiring Sphinx via tox to avoid maintaining two integrations. Here's how you call it then: https://github.com/ansible/awx-plugins/blob/e613d5a/.readthedocs.yaml. |
@webknjaz This looks way more complicated than what we currently have. |
It's necessary if we don't want to have the workflow of building locally for contributors to be "go read the source code and attempt to guess which command to run, where, in what env and how". |
@webknjaz I got your point and I added tox environment to build the docs locally. But I am not going to use it at readthedocs. Using their workflow seems way easier. |
Looks like RTD's command is slightly different: https://app.readthedocs.org/projects/pytest-rerunfailures/builds/26432307/#252451638--1. It's a good idea to keep both places in sync. It's also customary to run the docs build @ GHA additionally to keep the dev env healthy. |
I do not plan to improve this PR any further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The result looks like this: https://pytest-rerunfailures--284.org.readthedocs.build/284/