Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure for readthedocs #284

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Configure for readthedocs #284

merged 7 commits into from
Dec 3, 2024

Conversation

icemac
Copy link
Contributor

@icemac icemac commented Nov 22, 2024

@icemac icemac requested a review from hugovk November 22, 2024 07:51
.readthedocs.yaml Outdated Show resolved Hide resolved
icemac and others added 3 commits November 22, 2024 13:42
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@webknjaz
Copy link
Member

I recommend wiring Sphinx via tox to avoid maintaining two integrations.

Here's how you call it then: https://github.com/ansible/awx-plugins/blob/e613d5a/.readthedocs.yaml.

@icemac
Copy link
Contributor Author

icemac commented Nov 28, 2024

@webknjaz This looks way more complicated than what we currently have.

@webknjaz
Copy link
Member

@webknjaz This looks way more complicated than what we currently have.

It's necessary if we don't want to have the workflow of building locally for contributors to be "go read the source code and attempt to guess which command to run, where, in what env and how".

@icemac
Copy link
Contributor Author

icemac commented Nov 29, 2024

@webknjaz I got your point and I added tox environment to build the docs locally. But I am not going to use it at readthedocs. Using their workflow seems way easier.

@icemac icemac requested a review from hugovk November 29, 2024 07:21
@webknjaz
Copy link
Member

Looks like RTD's command is slightly different: https://app.readthedocs.org/projects/pytest-rerunfailures/builds/26432307/#252451638--1. It's a good idea to keep both places in sync. It's also customary to run the docs build @ GHA additionally to keep the dev env healthy.
Also, htmldir builder produces nicer URLs — consider using it on RTD but keeping html locally.

@icemac icemac enabled auto-merge (squash) December 3, 2024 16:51
@icemac
Copy link
Contributor Author

icemac commented Dec 3, 2024

I do not plan to improve this PR any further.
So I enabled auto-merge and started waiting for a review.
If someone wants to adopt this PR for further improvements, I can disable auto-merge again.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@icemac icemac merged commit c4992c3 into master Dec 3, 2024
83 checks passed
@icemac icemac deleted the readthedocs branch December 3, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants