Add a Scheduling Protocol #1061
Conversation
bluetech
commented
Apr 6, 2024
bluetech
commented
- Clearly delineate the required interface of schedulers
- Useful for typing
| dist = config.getvalue("dist") | ||
| schedulers = { |
There was a problem hiding this comment.
Not using the dict because I don't want to include the __init__ in the protocol (if that's even possible...)
| return LoadGroupScheduling(config, log) | ||
| if dist == "worksteal": | ||
| return WorkStealingScheduling(config, log) | ||
| return None |
There was a problem hiding this comment.
There is a semantic change here -- if dist is not one of the builtin schedulers, this hook now returns None instead of raising a KeyError before. This seems better to me, allowing other hookimpls (e.g. wrappers) to handle this more gracefully.
| @@ -103,6 +103,9 @@ def mark_test_complete(self, node, item_index, duration=0): | |||
| def mark_test_pending(self, item): | |||
| raise NotImplementedError() | |||
|
|
|||
| def remove_pending_tests_from_node(self, node, indices): | |||
There was a problem hiding this comment.
Some schedulers were missing this method that is used by DSession, if guess it's not called for them so raising NotImplementedError.
| from xdist.workermanage import WorkerController | ||
|
|
||
|
|
||
| class Scheduling(Protocol): |
There was a problem hiding this comment.
Minor, up to you: I think a more appropriate name would be Scheduler (a subject), "sheduling" is a verb AFAIK. But I understand also that all the implementations use Scheduling in their name, so on one hand it makes sense to name this Scheduling, on the other hand, "two wrongs don't make a right".
Up to you really. 👍
There was a problem hiding this comment.
Yes, I don't know why the existing schedulers are called Scheduling but I don't think we can safely change them at this point. And then I think being consistent is better.
Right, it's purely internal for now. If we want to expose it, would really need proper docs on the methods which I'm not really familiar with yet. |
- Clearly delineate the required interface of schedulers - Useful for typing
bluetech
force-pushed
the
scheduling-proto
branch
from
07eb3d1
to
bf2dccc
Compare
