Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip progress display when in non-terminal #55

Merged
merged 4 commits into from
May 13, 2016

Conversation

nicoddemus
Copy link
Member

@nicoddemus
Copy link
Member Author

Dropped pytest 2.4 and 2.5 from build Matrix and added pytest 2.9.

Question: do we really need to support such old pytest versions? I would think it reasonable to support only the most current and previous version, i. e. 2.8 and 2.9 currently.

@nicoddemus
Copy link
Member Author

@RonnyPfannschmidt any idea why the test suite is failing in pytest-2.9?

=================================== FAILURES ===================================
____________________________ test_remoteinitconfig _____________________________
testdir = <Testdir local('/tmp/pytest-of-travis/pytest-0/testdir/test_remoteinitconfig0')>
    def test_remoteinitconfig(testdir):
        from xdist.remote import remote_initconfig
        config1 = testdir.parseconfig()
        config2 = remote_initconfig(config1.option.__dict__, config1.args)
>       assert config2.option.__dict__ == config1.option.__dict__
E       assert {'assertmode'...': False, ...} == {'assertmode':...': False, ...}
E         Omitting 56 identical items, use -v to show
E         Differing items:
E         {'file_or_dir': ['/tmp/pytest-of-travis/pytest-0/testdir/test_remoteinitconfig0']} != {'file_or_dir': []}
E         Use -v to get the full diff
/home/travis/build/pytest-dev/pytest-xdist/testing/test_remote.py:69: AssertionError

@@ -722,17 +722,20 @@ def __init__(self, config):
self.tr = config.pluginmanager.getplugin("terminalreporter")
self._status = {}
self._lastlen = 0
self._isatty = self.tr.hasmarkup
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on first glance i think that instead of hasattr, we should use getattr(self.tr, 'isatty', self.tr.hasmarkup)

@RonnyPfannschmidt
Copy link
Member

off hand no idea

@nicoddemus
Copy link
Member Author

OK thanks, I will investigate later, although it seems this is broken in master already because it seems unrelated to my change.

@RonnyPfannschmidt
Copy link
Member

i would guess its related to the change @bukzor (?) did to fix wrong behavior wrt xdist context initialization

@nicoddemus
Copy link
Member Author

It's my hunch as well

@RonnyPfannschmidt
Copy link
Member

please xfail it and report an issue where we can solve it

@nicoddemus
Copy link
Member Author

Will do 😁

@nicoddemus
Copy link
Member Author

@RonnyPfannschmidt created #59 as we agreed.

Let me know your thoughts on this patch when you can. 😁

@RonnyPfannschmidt RonnyPfannschmidt merged commit c27ac36 into pytest-dev:master May 13, 2016
@RonnyPfannschmidt
Copy link
Member

thanks 👍

@nicoddemus
Copy link
Member Author

Thank you. I will take a look at #59 later.

@nicoddemus nicoddemus deleted the collect-report-atty branch May 13, 2016 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants