-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip progress display when in non-terminal #55
Skip progress display when in non-terminal #55
Conversation
519accf
to
d49e603
Compare
Dropped pytest 2.4 and 2.5 from build Matrix and added pytest 2.9. Question: do we really need to support such old pytest versions? I would think it reasonable to support only the most current and previous version, i. e. 2.8 and 2.9 currently. |
@RonnyPfannschmidt any idea why the test suite is failing in pytest-2.9?
|
@@ -722,17 +722,20 @@ def __init__(self, config): | |||
self.tr = config.pluginmanager.getplugin("terminalreporter") | |||
self._status = {} | |||
self._lastlen = 0 | |||
self._isatty = self.tr.hasmarkup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on first glance i think that instead of hasattr, we should use getattr(self.tr, 'isatty', self.tr.hasmarkup)
off hand no idea |
OK thanks, I will investigate later, although it seems this is broken in |
i would guess its related to the change @bukzor (?) did to fix wrong behavior wrt xdist context initialization |
It's my hunch as well |
please xfail it and report an issue where we can solve it |
Will do 😁 |
Latest tox seems to be broken in this regard, it is not stripping the comment from the dependency line
6acefc6
to
9786e3d
Compare
@RonnyPfannschmidt created #59 as we agreed. Let me know your thoughts on this patch when you can. 😁 |
thanks 👍 |
Thank you. I will take a look at #59 later. |
Similar to pytest-dev/pytest#1397