Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for Node.fspath deprecation #623

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Feb 7, 2021

calculate topdir based on config.rootpath/rootdir

addresses pytest-dev/pytest#8251

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix;

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the pytest-fspath-deprecation-prep branch from fec14eb to ef98f1b Compare February 7, 2021 19:40
calculate topdir based on config.rootpath/rootdir

addresses pytest-dev/pytest#8251
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the pytest-fspath-deprecation-prep branch from ef98f1b to aa89c42 Compare February 7, 2021 19:44
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants