Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.2 #830

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Release 3.0.2 #830

merged 8 commits into from
Oct 25, 2022

Conversation

nicoddemus
Copy link
Member

No description provided.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@nicoddemus
Copy link
Member Author

Oh oh.

It published pytest_xdist-0.0.0-py3-none-any.whl... setuptools-scm did not kick-in?

@nicoddemus
Copy link
Member Author

nicoddemus commented Oct 25, 2022

Weird, locally for me it generated correctly the package as 3.0.0... any ideas @RonnyPfannschmidt ?

@nicoddemus
Copy link
Member Author

Hmm seems like checkout@v2 does not check all tags:

https://github.com/pytest-dev/pytest-xdist/actions/runs/3320401672/jobs/5486795138

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +192193197bee27228e1e4b44855b3777397e31e5:refs/tags/v3.0.0

(See --no-tags above)

Will change the action to checkout all tags.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus actions/checkout#249 has been open sine a while now, they just keep avoiding adding a sensible way

@RonnyPfannschmidt
Copy link
Member

@nicoddemus yikes, new issue it seems, we may need the output with SETUPTOOLS_SCM_DEBUG=1 of the wheel build

@nicoddemus
Copy link
Member Author

Hmm no dice, it again tried to upload 0.0.0, however we can see in the logs that the tags were fetched this time: https://github.com/pytest-dev/pytest-xdist/actions/runs/3321716437/jobs/5489813241

...
   * [new tag]         v3.0.0                 -> v3.0.0
   * [new tag]         v3.0.1                 -> v3.0.1

This is really strange, as I never encountered this problem before. Any ideas @RonnyPfannschmidt ?

@RonnyPfannschmidt
Copy link
Member

@nicoddemus this is a completely new one for me as well - no idea yet whats wrong

@RonnyPfannschmidt
Copy link
Member

@nicoddemus i realized the error, its not using a propper build backend, so the install wont add setuptools_scm

@mdmintz
Copy link

mdmintz commented Oct 25, 2022

Might be unrelated, but pytest just removed py as a dependency, yet pytest-xdist has pytest-forked as a dependency, which has py as a dependency.

@RonnyPfannschmidt
Copy link
Member

@mdmintz that one is completely unrelated

@RonnyPfannschmidt
Copy link
Member

@nicoddemus i'll have a bugfix in about 10

@nicoddemus nicoddemus changed the title Release 3.0.0 Release 3.0.2 Oct 25, 2022
@nicoddemus
Copy link
Member Author

Yay finally, thanks @RonnyPfannschmidt for the quick fix. 👍

@nicoddemus nicoddemus merged commit 7949c14 into pytest-dev:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants