Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hookspec: deprecate hookimpls requesting py.path parameters #12227

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Apr 19, 2024

This adds the deprecation that we missed in 7.x (see #12069) so that we can remove them again in 9.x.

Uses new feature of pluggy to deprecate parameters, not yet merged released in pluggy 1.5: pytest-dev/pluggy#495

@bluetech bluetech added this to the 8.2 milestone Apr 19, 2024
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, lets put this into draft until we can depend on the new minimal pluggy version

changelog/12069.deprecation.rst Outdated Show resolved Hide resolved
@bluetech bluetech force-pushed the deprecate-legacy-path-impls branch from dca7eb3 to 5688acd Compare April 21, 2024 06:00
@bluetech bluetech force-pushed the deprecate-legacy-path-impls branch 2 times, most recently from 7d6fe29 to 0ce6ca3 Compare April 21, 2024 06:32
@bluetech bluetech force-pushed the deprecate-legacy-path-impls branch from 0ce6ca3 to 58136c5 Compare April 21, 2024 08:38
@bluetech bluetech merged commit 3617ef1 into pytest-dev:main Apr 21, 2024
24 checks passed
@bluetech bluetech deleted the deprecate-legacy-path-impls branch April 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants