Fixed Bug Regarding Attribute Error in pytest.approx For Types Implicitly Convertible to Numpy Arrays #12232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by reporter in issue pytest-dev#12114
…ed by reporter in issue pytest-dev#12114
RonnyPfannschmidt
requested changes
Apr 22, 2024
src/_pytest/python_api.py
Outdated
| @@ -163,6 +163,9 @@ def get_value_from_nested_list( | |||
| self._approx_scalar, self.expected.tolist() | |||
| ) | |||
|
|
|||
| # convert other_side to numpy array to ensure shape attribute is available | |||
| other_side = _as_numpy_array(other_side) | |||
There was a problem hiding this comment.
i believe we need to expand the type annotation to include objects which may cast to a array + use a new variable name like other_side_as_array + assert its not none
There was a problem hiding this comment.
Alright, I added those changes in a push. Let me know if the typing for other_side looks alright, currently it is set to other_side: Union["ndarray", List[Any]].
…rray and renamed other_side to other_side_as_array and asserted that it is not none
RonnyPfannschmidt
approved these changes
Apr 22, 2024
|
I presume you would like a squash commit instead of a merge |
|
Yeah that sounds good to me! |
|
Hi Ronny, I just wanted to clarify if I have to do anything else for this pull request? |
|
No, next step is merge,I'm just preoccupied |
|
thanks again ! |
|
Of course! Thank you for your help and guidance :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug for _repr_compare in the ApproxNumpy class located in pytest.approx to ensure that other_side is a numpy array before comparing np_array_shape != other_side.shape. I have verified that the provided test cases, along with the test case provided in #12114, have all passed using pytest testing/python/approx.py.