Prepare release 8.3.4

[github-actions]

Created by the prepare release pr workflow.

Once all builds pass and it has been approved by one or more maintainers, start the deploy workflow, using these parameters:

• Use workflow from: release-8.3.4.
• Release version: 8.3.4.

Or execute on the command line:

gh workflow run deploy.yml -r release-8.3.4 -f version=8.3.4

After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.

[Pierre-Sassoulas]

This workflow to approve release is great. I'm not familliar with it and didn't manage to approve the deploy (maybe it's impossible on mobile)

[nicoddemus]

@Pierre-Sassoulas weird, I am able to approve the deploy on mobile:

You definitely should be able to approve too... 🤔

[nicoddemus]

Deploy failed with:

ERROR    HTTPError: 502 Bad Gateway from https://upload.pypi.org/legacy/        
         Bad Gateway  

Updating the pypa/gh-action-pypi-publish action to v1.12.2 (same as main) and trying again.

[nicoddemus]

@Pierre-Sassoulas just triggered deploy again if you want to retry approving it.

[nicoddemus]

@Pierre-Sassoulas do not run the deploy workflow from main 😆

I cancelled them. 😁

You should get a notification about the deploy workflow running from this branch, like this:

[nicoddemus]

https://github.com/pytest-dev/pytest/actions/runs/12105551595

[nicoddemus]

Just double checked, the deploy workflow can be approved by @pytest-dev/core:

Which you are part of, so definitely you should be able to approve it.

[Pierre-Sassoulas]

Sorry about that 😅

It seems I can only cancel once in the job.

[nicoddemus]

Really strange, not sure why is that... just checked again and you are part of @pytest-dev/core, so don't know what's going on.

I will approve it myself to get the release out, we can investigate later. 👍

[nicoddemus]

@RonnyPfannschmidt @webknjaz deploy failed when trying to push the new tag, due to the recent changes in the repo Rulesets:

remote: error: GH013: Repository rule violations found for refs/tags/8.3.4.        
remote: Review all repository rules at https://github.com/pytest-dev/pytest/rules?ref=refs%2Ftags%2F[8](https://github.com/pytest-dev/pytest/actions/runs/12105551595/job/33750381462#step:5:9).3.4        
remote: 
remote: - Cannot create ref due to create name restrictions.        
remote: 
To https://github.com/pytest-dev/pytest
 ! [remote rejected] 8.3.4 -> 8.3.4 (push declined due to repository rule violations)

Not sure, the rules seem right to me? Can you please take a look?

I'm continue the release process manually from this point, given that we already published the package to PyPI.

[webknjaz]

Tag creations are forbidden: https://github.com/pytest-dev/pytest/rules?ref=refs%2Ftags%2F8.3.4. I don't have access to fix this.

[nicoddemus]

Oh, this is preventing tags that match the patterns from being created? I thought it was only allowing tags that match the patterns to be created.

@RonnyPfannschmidt?

[webknjaz]

Yeah, this should match all the tags instead and add exclusions for the allowed patterns.

[webknjaz]

I'd probably separate the rules even — creations and updates/deletions with stricter override privileges...

[RonnyPfannschmidt]

i updated the ruleset - allow creation, prevent deletion

[webknjaz]

But that doesn't block creating tags with arbitrary names..

[RonnyPfannschmidt]

i think i need to add a bypass for deploy keys or something like that

is there any coherent explanation of the system - learning by flailing sucks

[webknjaz]

i think i need to add a bypass for deploy keys or something like that

is there any coherent explanation of the system - learning by flailing sucks

Dunno. I had a chance to sit down and experiment with it quite a lot a few months ago. So if you'll document what you're doing publicly, I should be able to review that / give advice. Just remember to tag me :)