Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [tool:pytest] in setup.cfg files #1813

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

nicoddemus
Copy link
Member

Also deprecate [pytest] usage in setup.cfg files

Fix #567

@nicoddemus nicoddemus added this to the 3.0 milestone Aug 17, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 93.108% when pulling b792384 on nicoddemus:pytest-setup.cfg into d3b8551 on pytest-dev:features.

@@ -232,6 +232,11 @@ time or change existing behaviors in order to make them less surprising/more use
* ``yield``-based tests are considered deprecated and will be removed in pytest-4.0.
Thanks `@nicoddemus`_ for the PR.

* ``[pytest]`` sections in ``setup.cfg`` files should now be named ``[tool:pytest]``
to avoid conflicts with other distutils commands (see `#567`_). ``[pytest]`` in
``pytest.ini`` or ``tox.ini`` files are supported and unchanged.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (feel free to ignore): "[pytest] sections in ...." or "is supported"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks, it is better really.

@RonnyPfannschmidt
Copy link
Member

while we are at it, we might want to support [tool:pytest] in tox.ini as well

@RonnyPfannschmidt RonnyPfannschmidt added the status: critical grave problem or usability issue that affects lots of users label Aug 17, 2016
Also deprecate [pytest] usage in setup.cfg files

Fix pytest-dev#567
@nicoddemus
Copy link
Member Author

while we are at it, we might want to support [tool:pytest] in tox.ini as well

Not sure @RonnyPfannschmidt... I consider supporting [tool:pytest] in setup.cfg more like a workaround a distutils/setuptools limitation than a feature. We don't have the same problems with tox.ini.

If we add the same support to tox.ini, it kind of follows that we should also support [tool:pytest] for pytest.ini files as well, and I'm not sure this is a good idea.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 93.111% when pulling ab86dea on nicoddemus:pytest-setup.cfg into 09e647c on pytest-dev:features.

@RonnyPfannschmidt
Copy link
Member

main reason im proposing it, is to set a stage - after all pytest.ini we own, but tox.ini is owned by tox and setup.cfg is owned by distutils

@nicoddemus
Copy link
Member Author

I see. But perhaps we should do it in a separate issue/PR? It's just that I would not like to rush this in without some discussion, perhaps involving more people.

@RonnyPfannschmidt
Copy link
Member

good point - the tox ini handling can be deffered to a later release in any case

@nicoddemus
Copy link
Member Author

Anything else? Can we merge this?

@The-Compiler The-Compiler merged commit 789e467 into pytest-dev:features Aug 17, 2016
@nicoddemus nicoddemus deleted the pytest-setup.cfg branch August 17, 2016 18:40
@nicoddemus
Copy link
Member Author

Thanks! 😁

@hackebrot
Copy link
Member

👍 great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: critical grave problem or usability issue that affects lots of users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants