-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when pytest.warns fail #2150
Merged
nicoddemus
merged 2 commits into
pytest-dev:master
from
lesteve:add-caught-warnings-info-when-warns-fail
Dec 26, 2016
Merged
Improve error message when pytest.warns fail #2150
nicoddemus
merged 2 commits into
pytest-dev:master
from
lesteve:add-caught-warnings-info-when-warns-fail
Dec 26, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message contains the expected type of warnings and the warnings that were captured. Add tests.
following contribution guidelines
Oh, that seems quite useful. Nice work 👍 |
Nice work! Tests fail due to unrelated failures on the |
This was referenced Jan 22, 2017
This was referenced Feb 21, 2018
This was referenced Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message contains the expected type of warning and the
warnings that were captured. Add tests.
You could argue that having the stderr is good enough but in my original use case, either the stderr was very noisy or I managed to miss it completely. I reckon it does not hurt to have a clearer error message anyway.
The line of the error message is very long now. Let me know if you would rather have me split it manually or you have better ways to deal with it.
Simple snippet:
master:
This PR: