Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new pytest_report_collectionfinish hook #2623

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Introduce new pytest_report_collectionfinish hook #2623

merged 1 commit into from
Jul 27, 2017

Conversation

nicoddemus
Copy link
Member

Fix #2622

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 91.886% when pulling 17c544e on nicoddemus:post-collection-report-hook into ddf1751 on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt merged commit e97fd5e into pytest-dev:features Jul 27, 2017
@nicoddemus nicoddemus deleted the post-collection-report-hook branch July 27, 2017 15:19
@nicoddemus
Copy link
Member Author

Thanks!

@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Jul 31, 2017
Closed
@RonnyPfannschmidt
Copy link
Member

@nicoddemus i just noticed that we run that hook only when we do not do collectonly, i wonder if that is actually a good idea that way around

@nicoddemus nicoddemus mentioned this pull request Nov 4, 2017
Closed
@nicoddemus
Copy link
Member Author

Good point: #2895

I will get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @coveralls @RonnyPfannschmidt