[WIP] raise exception when fixture is applied to marked function #4122
Conversation
|
No problem! |
nicoddemus
changed the title
|
(I've added "WIP" to the title to make it explicit that this is not ready for review/merge) |
|
oh makes sense! thanks. |
| @@ -956,6 +956,8 @@ def pytest_fixture_setup(fixturedef, request): | |||
| kwargs[argname] = result | |||
|
|
|||
| fixturefunc = resolve_fixture_function(fixturedef, request) | |||
| if hasattr(fixturefunc,'pytestmark'): | |||
There was a problem hiding this comment.
to avoid exceptions being eaten on python2, its critical to use getattr(fixturefunc,'pytestmark', False) instead
to be documentative perhaps getattr(fixturefunc,'pytestmark', None) is not None even
|
Hi @avirlrma, It has been a long time since it has last seen activity, plus we have made sweeping changes on In order to clear up our queue and let us focus on the active PRs, I'm closing this PR for now. Please don't consider this a rejection of your PR, we just want to get this out of sight until you have the time to tackle this again. If you get around to work on this in the future, please don't hesitate in re-opening this! Thanks for your work, the team definitely appreciates it! |
sorry I the original PR got closed as I removed the commit from the master.
Ed: closes #3664, once finished.