Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the junit_log_passing_tests ini flag to skip logging output for passing tests. #5052

Conversation

jeffreyrack
Copy link
Member

Closes #4559 by adding the junit_log_passing_tests ini flag which can be turned off to disable logging test output and logging for passing tests in the junit XML report.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #5052 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5052      +/-   ##
============================================
+ Coverage     96.07%   96.07%   +<.01%     
============================================
  Files           114      114              
  Lines         25778    25790      +12     
  Branches       2552     2553       +1     
============================================
+ Hits          24765    24777      +12     
  Misses          704      704              
  Partials        309      309
Impacted Files Coverage Δ
testing/test_junitxml.py 97.83% <100%> (+0.02%) ⬆️
src/_pytest/junitxml.py 95.26% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04936f...da3f836. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot @jeffreyrack! 👍

Really sorry about the delay on this, it seems this has slipped through the cracks.

@nicoddemus nicoddemus merged commit b10f289 into pytest-dev:features May 29, 2019
@andkononykhin
Copy link

@jeffreyrack @nicoddemus Hello. Thank you for that option but seems the change introduces one drawback: it disables any junit logging for failed tests which don't fail during teardown phase.

@twmr
Copy link
Contributor

twmr commented Jun 3, 2019

@andkononykhin Hi, thank you very much for the report. Can you create a ticket/issue for this regression with a minimal example please? Thx

@andkononykhin
Copy link

@Thisch I created #5430. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants