Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: Temporary pin setup-python GH action to v2.1.4 #8171

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

antonblr
Copy link
Member

@antonblr antonblr commented Dec 18, 2020

Fix for #8170 to address CI builds failure (will revert it once underlying issue is fixed)

EDIT: setup-python fix is out - actions/setup-python#172 (perhaps, we could update to new syntax too)

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antonblr!

What's the new syntax you mention? I did glance quickly at the README but didn't notice anything different. 😁

@nicoddemus nicoddemus merged commit 403424d into pytest-dev:master Dec 18, 2020
@antonblr antonblr deleted the fix-ci-setup-python branch December 18, 2020 15:39
@antonblr
Copy link
Member Author

@nicoddemus - it was mentioned on the issue actions/setup-python#171 (comment)
Seems like there should be a dash followed by python major.minor version, like pypy-3.7 or pypy-3.8 (vs pypy3 we have right now)

@nicoddemus
Copy link
Member

Ahh I see, thanks! Sure, no problem in using the new syntax.

@asottile
Copy link
Member

looks like actions/setup-python#171 is fixed now -- I've opened #8172 with a revert + update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants